Skip to content

fix(blurbs): read a blurb in a note and name icon links by their label - #274

Merged
CalvinAllen merged 1 commit into
mainfrom
fix/blurbs/notes-in-asides
Nov 18, 2026
Merged

CalvinAllen merged 1 commit into
mainfrom
fix/blurbs/notes-in-asides

Conversation

@CalvinAllen

Copy link
Copy Markdown
Member

What happened

An author's post showed Missing blurb although it opens with one. Their blog sets the blurb off in a "Note" box, written as an <aside> inside the post's <article>. ArticleReader removed every aside as a sidebar, so the link back went with it, and since the page was clearly the post, the check failed it without asking Claude (no quote or reason on the row).

The same page has a permalink and five share buttons at the top that are icons with no words. The reader used each one's address as its words, about 1,500 characters in all, so even with the note kept, the blurb started at character 1,694 of the 2,000 read. One more share button would have pushed it out.

The fix

  • 📝 Asides: one inside the article is part of the post (a note, by HTML's meaning of aside). Any other is still the site's sidebar and dropped, as is anything marked role=complementary.
  • 🔗 Icon links: a link with no words is named by its aria-label, an image's alt or its title, what a screen reader announces, and by its address only without any of them.

On the real page, the reader before this finds no link back; after it, the blurb's link is at character 214.

Tests

  • New in ArticleReaderTests: a blurb in a note inside the post (minified, unquoted attributes, like the real page), an aside on a page with no article, and icon links named by their labels.
  • The existing test's newsletter aside now sits beside the article, as a sidebar.
  • dotnet build is clean and the 1,162 unit tests pass locally. The integration tests couldn't start locally (Aspire reported the local Docker as unhealthy), so CI runs them here.

After deploying

Check now on the affected post's row passes it.

@CalvinAllen CalvinAllen changed the title fix(blurbs): read a blurb set off in a note, and name icon links by their label fix(blurbs): read a blurb in a note and name icon links by their label Nov 18, 2026
A post that opened with the blurb in a "Note" box, an aside inside its
article, was marked missing without asking Claude: the reader dropped
every aside as a sidebar, link back and all. An aside inside the article
is now part of the post; any other is still the site's sidebar.

The same post's share buttons are icons with no words, so each counted
its whole address (hundreds of characters) toward the opening, putting
the blurb near the end of the 2,000 read. A link with no words is now
named by its aria-label, an image's alt or its title, and only by its
address without any of them.
@CalvinAllen
CalvinAllen force-pushed the fix/blurbs/notes-in-asides branch from 340cf0d to 1dd1bad Compare November 18, 2026 21:12
@CalvinAllen
CalvinAllen merged commit 51ba0ad into main Nov 18, 2026
3 checks passed
@CalvinAllen
CalvinAllen deleted the fix/blurbs/notes-in-asides branch November 18, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant