Repository navigation
fix(blurbs): read a blurb in a note and name icon links by their label - #274
Merged
Merged
Conversation
A post that opened with the blurb in a "Note" box, an aside inside its article, was marked missing without asking Claude: the reader dropped every aside as a sidebar, link back and all. An aside inside the article is now part of the post; any other is still the site's sidebar. The same post's share buttons are icons with no words, so each counted its whole address (hundreds of characters) toward the opening, putting the blurb near the end of the 2,000 read. A link with no words is now named by its aria-label, an image's alt or its title, and only by its address without any of them.
CalvinAllen
force-pushed
the
fix/blurbs/notes-in-asides
branch
from
November 18, 2026 21:12
340cf0d to
1dd1bad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
An author's post showed Missing blurb although it opens with one. Their blog sets the blurb off in a "Note" box, written as an
<aside>inside the post's<article>.ArticleReaderremoved everyasideas a sidebar, so the link back went with it, and since the page was clearly the post, the check failed it without asking Claude (no quote or reason on the row).The same page has a permalink and five share buttons at the top that are icons with no words. The reader used each one's address as its words, about 1,500 characters in all, so even with the note kept, the blurb started at character 1,694 of the 2,000 read. One more share button would have pushed it out.
The fix
articleis part of the post (a note, by HTML's meaning ofaside). Any other is still the site's sidebar and dropped, as is anything markedrole=complementary.aria-label, an image'saltor itstitle, what a screen reader announces, and by its address only without any of them.On the real page, the reader before this finds no link back; after it, the blurb's link is at character 214.
Tests
ArticleReaderTests: a blurb in a note inside the post (minified, unquoted attributes, like the real page), an aside on a page with no article, and icon links named by their labels.asidenow sits beside the article, as a sidebar.dotnet buildis clean and the 1,162 unit tests pass locally. The integration tests couldn't start locally (Aspire reported the local Docker as unhealthy), so CI runs them here.After deploying
Check now on the affected post's row passes it.