FEAT : add ts, prettier, vitest and CI - #1
Merged
Merged
Conversation
CMarzin
commented
Jul 17, 2025
CMarzin
commented
Owner
- Update roadmap package
- Add Typescript instead of babel
- Add test
- Add CI
- Add format prettier
adrienZ
reviewed
Jul 22, 2025
| with: | ||
| node-version: '20.17.0' | ||
|
|
||
| - name: Install dependencies |
There was a problem hiding this comment.
npm ci is what you want to do since it will NOT write your package-lock, I think you can remove this step
adrienZ
reviewed
Jul 22, 2025
| [x] Add CI | ||
| [x] Add Typescript | ||
| [x] Add License | ||
| [ ] Add the possibility to create a pull request for Github. |
adrienZ
reviewed
Jul 22, 2025
adrienZ
reviewed
Jul 22, 2025
There was a problem hiding this comment.
Seems weird to push coverage results, you might want to use https://about.codecov.io/
adrienZ
reviewed
Jul 22, 2025
| }: MergeRequestData) { | ||
| let mergeRequestUrl = '' | ||
|
|
||
| mergeRequestUrl += `source_branch=${sourceBranch}` |
There was a problem hiding this comment.
you might want to use https://developer.mozilla.org/fr/docs/Web/API/URLSearchParams to handle such case
adrienZ
reviewed
Jul 22, 2025
| "test": "vitest run", | ||
| "test:coverage": "vitest run --coverage", | ||
| "test:watch": "vitest --coverage.enabled --ui", | ||
| "ci": "npm run build && npm run check-format && npm run test" |
There was a problem hiding this comment.
while this works, keep in mind that ci is a reserved keyword https://docs.npmjs.com/cli/v8/commands/npm-ci
adrienZ
reviewed
Jul 22, 2025
| "test": "vitest run", | ||
| "test:coverage": "vitest run --coverage", | ||
| "test:watch": "vitest --coverage.enabled --ui", | ||
| "ci": "npm run build && npm run check-format && npm run test" |
There was a problem hiding this comment.
Suggested change
| "ci": "npm run build && npm run check-format && npm run test" | |
| "ci": "npm ci && npm run build && npm run check-format && npm run test" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.