Skip to content

Fix/event date email - #273

Merged
mateodurante merged 3 commits into
developfrom
fix/event-date-email
Aug 21, 2026
Merged

Fix/event date email#273
mateodurante merged 3 commits into
developfrom
fix/event-date-email

Conversation

@mateodurante

Copy link
Copy Markdown
Contributor

This pull request introduces several improvements focused on visual consistency, accessibility, and localization in reports and notification templates. The main changes include updating priority color codes, enhancing support for dark mode, improving the display of priority and TLP levels, and refining event date handling and translations.

Visual and Theming Improvements:

  • Updated the color values for different priority levels in priority.json to use distinct, meaningful colors instead of white, improving clarity and visual differentiation. [1] [2] [3] [4]
  • Added meta tags to base_head.html and CSS rules to email.css to support light/dark color schemes, ensuring better appearance in dark mode and consistent background for headers. [1] [2]

Report Header and Display Enhancements:

  • Modified the header styles in base_header_right.html to display priority and TLP levels with a black background and the specified color for improved readability and emphasis.

Localization and Event Date Handling:

  • Improved the event report template and translation files to support both event date and creation date, and added a translation for "Event creation date" to provide clearer information in reports. [1] [2]

Copilot AI lite review requested due to automatic review settings August 21, 2026 14:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates report/email templates and related localization/fixtures to improve priority/TLP visual presentation, add dark-mode signaling, and clarify event timestamp display (event date vs creation date).

Changes:

  • Updated priority fixture colors to distinct values for clearer differentiation.
  • Added email dark-mode meta tags and CSS overrides, and adjusted header styling for priority/TLP pills.
  • Updated the basic event report to display either “Event Date” or “Event creation date”, plus added the Spanish translation entry.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ngen/templates/reports/email.css Adds prefers-color-scheme handling for email rendering.
ngen/templates/reports/basic_event_report.html Shows event date if present, otherwise creation date (with translated label).
ngen/templates/reports/base_header_right.html Improves priority/TLP pill readability with a black background.
ngen/templates/reports/base_head.html Adds color-scheme meta tags for better dark-mode behavior in email clients.
ngen/locale/es/LC_MESSAGES/django.po Adds Spanish translation for “Event creation date”.
ngen/fixtures/priority.json Updates priority color values to non-white, distinct colors.
Suppressed comments (1)

ngen/templates/reports/basic_event_report.html:31

  • The Notes section opens a tag but never closes it, and the {% endif %} is currently placed inside the <small> block. This produces invalid HTML and can lead to inconsistent rendering in email clients.
{% if event.notes %}
<small class="lead"><strong>{% translate 'Notes' %}:</strong>
    <div style="word-wrap: break-word;">{{ event.notes | render_report_content:event }}</div>
    <br>
    {% endif %}

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread ngen/locale/es/LC_MESSAGES/django.po Outdated
@mateodurante
mateodurante merged commit 15afc8c into develop Aug 21, 2026
5 checks passed
@mateodurante
mateodurante deleted the fix/event-date-email branch August 21, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants