Repository navigation
fix(ci): verify the release signature digest across build-tools releases - #71
Merged
Merged
Conversation
build-tools 37 labels apksigner's signer as `V2 Signer` instead of `Signer #1`, so the release signature check never matched and failed the step without any output. Match the digest at the end of any signer line and print the certificate when it does not match.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android Build的 release 产物校验在 ry.8 上失败了：build-tools 37.0.0 把apksigner verify --print-certs的输出标签从Signer #1 certificate SHA-256 digest:改成了V2 Signer: certificate SHA-256 digest:，原来的grep -Fqi "Signer #1 ..."因此永远匹配不上，set -e下静默退出 1，构建出来的 APK 也被判定为校验失败（上传产物步骤被跳过）。改动只在校验逻辑本身：匹配任意签名行末尾的证书摘要，并在不匹配时打印证书内容，避免再次出现无输出的失败。
验证：
bash -n通过；workflow YAML 解析通过。范围仅为
.github/workflows/android-build.yml，不涉及应用代码。