Skip to content

Correct SUV calculation in get_suv_constants - #11

Merged
ChristianHinge merged 4 commits into
masterfrom
carl-dev
Aug 28, 2026
Merged

Correct SUV calculation in get_suv_constants#11
ChristianHinge merged 4 commits into
masterfrom
carl-dev

Conversation

@carlvillads

Copy link
Copy Markdown
Member

Updates get_suv_constants in rhscripts/dcm.py.
SUV-bw should be calculated from the SeriesTime DICOM tag instead of the AcquisitionTime tag

  • Add time_tag parameter to get_suv_constants, allowing to choose between using Series Time ((0008,0031)) or Acquisition Time ((0008,0032)) for time calculations, if Acquisition Time is still preferred.
  • Updated dcmread with stop_before_pixels=True since pixel data is not needed for header information

@ChristianHinge

Copy link
Copy Markdown
Contributor

Personligt vil jeg foretrække at funktionen giver en error hvis SeriesTime ikke eksisterer, frem for at defaulte til AcquisitionTime. Jeg frygter at det kan skabe nogle silent errors. SeriesTime bør altid eksistere for PET.

@carlvillads

Copy link
Copy Markdown
Member Author

Personligt vil jeg foretrække at funktionen giver en error hvis SeriesTime ikke eksisterer, frem for at defaulte til AcquisitionTime. Jeg frygter at det kan skabe nogle silent errors. SeriesTime bør altid eksistere for PET.

Giver god mening – jeg får lige lavet en ny commit

@carlvillads

Copy link
Copy Markdown
Member Author

@ChristianHinge hvad siger du til denne ændring?

...
# Scan time
if time_tag == 'series':
    acq_time = ds[0x0008,0x0031].value  # Series time
elif time_tag == 'acquisition':
    acq_time = ds.AcquisitionTime
else:
    raise ValueError("'time_tag' must be 'series' or 'acquisition'")
...

Har også dobbelttjekket selve tagget (for en sikkerheds skyld), og det burde være det korrekte

@ChristianHinge
ChristianHinge marked this pull request as ready for review February 6, 2026 06:44
@carlvillads

Copy link
Copy Markdown
Member Author

@ChristianHinge hvem skal merge?

@ChristianHinge

Copy link
Copy Markdown
Contributor

lgtm :-)

@ChristianHinge
ChristianHinge merged commit 28999c3 into master Aug 28, 2026
0 of 2 checks passed
@carlvillads
carlvillads deleted the carl-dev branch August 29, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants