Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
标题准确概括了主要修复：将 OpenCode v2 的原生 default variant 读取为目录中的 Default 选项。标题简洁、明确，并与变更内容一致。 |
| Description check | |
描述与变更内容直接相关。它说明了问题原因、v2 状态转换逻辑、例外处理、测试覆盖范围和验证结果。 |
| Linked Issues check | |
PR 实现了 #528 的编码归一化要求。v2State() 现在调用 effectiveVariant()；当原生变体为 "default" 且模型没有该名称的真实变体时，返回目录默认 ID ocv.default。模型声明真实 default 变体时保留其编码 ID。显式 high 变体保持原 ID。新增的三个 v2 Thinking state 测试覆盖这些情况，并验… |
| Out of Scope Changes check | |
变更仅涉及 OpenCode v2 状态转换及其定向测试。测试直接验证 #528 的默认和显式 Thinking 变体映射。未发现与 #528 无关的生产代码、v1 行为或 schema 变更。 |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
1 participant
Summary
OpenCode v2 的会话读取接口把默认 Thinking 变体原样返回为字符串
"default"。v2Catalog()用encodeOpenCodeVariant(undefined)表示默认档位（ocv.default），而v2State()把原生的"default"当成普通变体名编码成ocv.ZGVmYXVsdA，不在该模型的availableThinkingOptions里，于是harnessConfigurationStateSchema拒绝状态，界面显示「无法切换模型 / Model state was not confirmed」，而原生会话其实已经切换。改动只在 v2 原生状态转换边界（
packages/adapters/opencode/src/v2/state.ts）：effectiveVariant()：原生变体为"default"，且该模型的supportedThinkingOptionIds里没有名为default的真实变体时，映射为目录的 Default 选项ocv.default。default的变体，保留其原有 ID，不做合并。encodeOpenCodeVariant/opencode-adapter.ts）和状态 schema 校验都没有改动。Related issues
Fixes #528
Test plan
packages/adapters/opencode/test/v2.test.ts中的OpenCode v2 Thinking state三个用例（原生"default"→ocv.default且在可用列表中；模型自己声明default变体时保留；显式变体high保持原 ID）。reads the native default variant as the catalog's Default option失败，expected 'ocv.ZGVmYXVsdA' to be 'ocv.default'。npx tsc -b后npx vitest run --config tests/vitest.config.js packages/adapters/opencode/test/：12 files passed / 2 skipped（real 测试），123 passed / 3 skipped。npx tsc -p tests/tsconfig.json --noEmit：通过。npx eslint两个改动文件、node tools/check-boundaries.mjs、npx prettier --check两个改动文件：通过。npm test（含 Rust 部分），只跑了 OpenCode adapter 的定向测试。Node v24.21.0，Linux x64。AI assistance disclosure: this change was prepared with help from an AI coding assistant. I reviewed the diff and ran the commands listed above myself.