val: finding context and coverage fields — not for merge - #18
Closed
sakanni wants to merge 5 commits into
Closed
Conversation
Revit repo specifically: ProjectParameter is version-conditional here, and BH.Revit.Engine.Core is the namespace #161 concerns, so both new fields should have something to say. Not for merge.
Contributor
Author
|
Validation complete, recorded on the CI_Toolkit PR. Three runs: one exposed the #192 parse error on the first cache miss, one showed the runner binary was develop's because prepare-runner builds from its own ref, and the third exercised all four surfaces cold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sandbox validation for the finding-context work. Revit repo chosen deliberately:
ProjectParameteris version-conditional here andBH.Revit.Engine.Coreis the namespace #161 concerns.Confirming: the grep finds the version-conditional methods, the coverage denominator appears, DeclaringTypeCandidates records ambiguity where it exists, the annotation carries the cause clause, and the summary shows the Known cause column.