Only show draft banner for genuinely unpublished memos#39
Merged
Conversation
The DRAFT preview banner was gated solely on the viewer being a logged-in admin, so every memo — including published ones — showed the orange "DRAFT — not yet published" bar to admins. Gate it on the memo's actual publish state instead: a memo is a draft only when it has no publishedAt, or one scheduled in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The DRAFT preview banner on memo pages was gated solely on the viewer being a logged-in admin (
accessToken), with no reference to the memo's publish status. As a result, every memo — including published ones — showed the orange "DRAFT — not yet published" bar to any admin.This gates the banner on the memo's actual publish state. A memo is treated as a draft only when it has no
publishedAt, or one scheduled in the future:Published memos no longer show the preview banner to admins; genuine drafts (and scheduled-but-not-yet-live memos) still do.
Testing