fix: prioritize group settings over user settings - #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!translate-all-on en esconfirmed English ↔ Spanish, but that author's messages could still auto-translate to Persian if they had a leftover personal pair (!translate-me-on fa en). Reply!translate eslooked fine because it never reads stored pairs.While group-wide is on, everyone now uses the group pair.
!translate-me-onis refused until!translate-all-off; leftover personal pairs stay saved and apply again after group-wide is off. Detection also skips a third language instead of forcing it into the pair (so Spanish in a Persian/English pair is not labeled English → Persian).Test plan
!translate-all-on en es, then send English and Spanish — they swap even after a prior!translate-me-on fa en!translate-me-onwhile group-wide is on — refused, with a note to!translate-all-offfirst!translate-all-offthen!translate-me-on— personal auto works again!translate esstill translates the quoted messagenpm run ci(fmt, clippy, coverage ≥90%)