Conversation
When a machine is failed it actually sends the machine usage failure email now
Added an audit log message for when a user logs in, will be helpful for debugging and other future work
Have the information people input into the machine failure form actually get sent to the backend, and actually use the MachineFailRequest. Also added the alembic migration for my previous commit
Added success message (note this has no loading circle as the email takes a few seconds to send and clarified the email
Added success message (note this has no loading circle as the email takes a few seconds to send and clarified the email
Emails just take a few seconds to send, so Ive added a spinner so that the user is not confused
Julesc27
previously approved these changes
Sep 16, 2026
Julesc27
left a comment
Julesc27
left a comment
Collaborator
There was a problem hiding this comment.
works good just 2 notes i would say one free reprint if they used forge filament. we don't offer reprints for people with their own filament. other thing when the machine is failed the percentage keeps going up as it's in use still. I feel like it should stop once the form is filled out.
Collaborator
|
It might be better to only include the free reprint text iff both the own filament and reprint boxes are unchecked and change the text to something "this print has 1 free reprint remaining". |
Collaborator
Author
The specific forge rule is now stated more precisely in the email, I decided not to have different failure emails so people are not confused about the rules and so people who use their own filament see their disadvantage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think after this, we've hit MVP! This is the third kind of email our website sends, the machine failure email which informs users that their machine usage has failed and they need to come back to the forge. I also added a new log type for user login now so that there aren't issues in the future with early records not existing.
Machine Usage Failure Email
The frontend had a form that collected lots of data from the volunteer who failed the machine, and we never did anything with it and never sent it to the backend. This is fixed now and we now actually use the
MachineFailRequestthat already existed to save that information in the Audit Log entry. The machine failure email now also actually gets sent.Added USER_LOGIN for AuditLog
I wanted to get this merged in before anything is deployed so that we had login records going back to the beginning. This will be useful for debugging and future features. This required yet another alembic migration, adding it to the enum, and actually creating the AudtLog entry in
/loginMachine Failure Email Example