Repository navigation
Conversation
The application list stretched to fill the screen down to Device Status, so a board offering one application left an empty grey band under its card. The list now grows only as tall as its cards and still shrinks to scroll when they do not fit.
Collaborator
Author
|
Closing without merging: the fixed-height, scrollable application area above Device Status is the intended design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
With a board that offers a single application, such as the AkidaTag with Keyword Spotting, the Select the Application screen showed an empty grey band inside the application list under the card, down to Device Status.
The list's frame used
flex: 1and its scroll viewflex: 1, so the frame always stretched to every pixel between the title and Device Status, whatever its cards needed. With two applications the cards overflow that space, which hid the problem on the BrainBoard1500.The frame now only shrinks (
flexShrink: 1) and the scroll view no longer grows (flexGrow: 0). The list is exactly as tall as its cards, and when the cards do not fit it still shrinks to the space above Device Status and scrolls, as before. Device Status now sits right under the list instead of at a fixed height near the bottom, which leaves the free space below it rather than inside the list.__tests__/applicationListHeight.test.tsxpins both halves: the list does not grow into free space, and it still shrinks to scroll. It fails on main and passes here.How to test
scripts/build-standalone-debug-apk.sh; it is already on the phone).