Rename DownloadButton to DownloadPanel - #20
Merged
Conversation
The component renders a full OS-selection panel with release metadata and download links, not a single button. Rename the server component and its client counterpart, their files, and the stale DownloadButtonProps type so the names match what they actually render. Closes #2
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2.
DownloadButtonrenders an OS-selection grid, release metadata, a pre-releasedisclaimer, and two action buttons — a panel, not a button. This renames it to
match.
components/DownloadButton.tsxcomponents/DownloadPanel.tsxcomponents/DownloadButtonClient.tsxcomponents/DownloadPanelClient.tsxDownloadButtonProps(types/releases.ts)DownloadPanelPropsThe issue named only the server component, but its client half carries the same
misleading name and is only ever rendered by it, so renaming one without the
other would leave the pair inconsistent. Callsite (
app/download/page.tsx) andthe prose references in
lib/releases.tsand.github/CONTRIBUTING.mdfollow.Rename only — no behavior change.
lint,typecheck,format:check, andnext buildall pass;/downloadstill prerenders.