Repository navigation
Reject tokens returned after sender authority is revoked - #130
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If an administrator disabled an outbound profile or unlinked its service link while a token response was in flight, the sender could cache and return that token after the durable authority had been removed. Recheck the current durable profile after the complete token response, before caching or returning it, so the pending business request is denied. Keep the existing cache-hit authority check, token limits, network policy and retry behavior.
Add six SQLite/PostgreSQL cases that hold the actual authenticated token response while unchanged authority, profile disable or administrator unlink completes. The enabled control sends an authorized request and reuses its cached token; both revoked cases deny the business request and leave the token cache empty. The central companion version remains
0.1.1-beta.12.Refs #128; companion continuation: BostonTechnologies/netratel#164. Actual cross-product acceptance will use the published companion build.
Validation
Helpdesk.slnRelease build: 0 errors, 21 preserved warnings.dotnet test Helpdesk.sln --configuration Release --no-build: 1,995 passed, 0 failed, 6 unchanged baseline skips (2,001 distinct test IDs).Disclosure check