This repository was archived by the owner on May 12, 2026. It is now read-only.
fix: preserve dropped image attachments#3786
Open
shriram-svg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2847.
What changed
:storage/...attachment markdown with POSIX separators so Windows drops do not insert backslashes into markdown image URLs.Verification
npx --yes -p node@20 node node_modules/jest/bin/jest.js tests/dataApi/attachmentManagement.test.js --runInBand --testURL=http://localhostnpx --yes -p node@20 node node_modules/eslint/bin/eslint.js browser/main/lib/dataApi/attachmentManagement.js tests/dataApi/attachmentManagement.test.jsgit diff --checkNotes:
yarn install --frozen-lockfileis blocked by the legacy lockfile'sgit://github.com/adobe-webplatform/eve.git#eef80eddependency, which Yarn v1 cannot resolve from advertised refs. I usednpm install --package-lock=false --ignore-scripts --legacy-peer-depsfor local verification without committing dependency metadata.npm run jest -- --runInBand --testURL=http://localhoststill has existing unrelated storage lookup failures increateNote,deleteFolder,createNoteFromUrl,createFolder, andfind-storage; the updatedattachmentManagementsuite passes.npm run lint -- --quietstill fails on existing project-widestyleName/prettier errors unrelated to these files; ESLint passes on the touched files.