Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Apply Linux no-sandbox launch flag#1689

Open
shriram-svg wants to merge 1 commit into
BoostIO:masterfrom
shriram-svg:fix-issue-244-linux-sandbox
Open

Apply Linux no-sandbox launch flag#1689
shriram-svg wants to merge 1 commit into
BoostIO:masterfrom
shriram-svg:fix-issue-244-linux-sandbox

Conversation

@shriram-svg
Copy link
Copy Markdown

Summary

  • add --no-sandbox to Linux package launcher args
  • append the same Electron command-line switch in the packaged Linux main process before ready
  • avoid duplicating the switch when it is already present from launcher metadata

This covers both desktop launcher startup and direct AppImage/deb binary startup for Debian-based systems where Electron aborts on a misconfigured chrome-sandbox helper.

Closes #244.

Verification

  • node -e electron-builder config validation for package.json#build
  • npx npm@6 run lint
  • npx npm@6 run test-api -- --runInBand
  • ./node_modules/.bin/tsc --noEmit --pretty false
  • ./node_modules/.bin/prettier --check package.json src/electron/index.ts
  • git diff --check
  • NODE_OPTIONS=--openssl-legacy-provider NODE_ENV=production BOOST_HUB_BASE_URL=https://boostnote.io ./node_modules/.bin/ts-node -P tsconfig-webpack.json scripts/build-electron-main.ts

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.deb package file is broken

3 participants