fix: stop stray remote worker supervisors and align brief decision keys - #13
Open
BohnBawerick wants to merge 2 commits into
Open
fix: stop stray remote worker supervisors and align brief decision keys#13BohnBawerick wants to merge 2 commits into
BohnBawerick wants to merge 2 commits into
Conversation
Generated ship, scout, dreamer, and secondmate briefs now include literal needs-decision and resolved lines with [key=<slug>] before the colon, matching the documented position.
…osts Linux remote-job start stacked supervisors when worker.pid was stale, so heavy e2e scripts leaked process groups and missed observable waits. Stop stray supervisors for that code root before launching another. Tests now wait on observables instead of pid 1 or tick counts, reap daemons by pid, skip a herdr pane that never becomes ready, and hoist repeated PR-check fixtures.
BohnBawerick
force-pushed
the
fm/fm-suite-unusable
branch
from
August 21, 2026 13:13
1b31bc7 to
1b63cc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
The developer wanted to recover and complete a major memory architecture update for Firstmate, including a compiled working memory system, drop-tray capture, and an idle dreamer consolidation agent. They instructed the assistant to prioritize and parallelize the memory slices while standing down other projects like VoiceMaster. They directed the assistant to autonomously implement, test, validate, land, and push all slices to the fork and local repository while utilizing available models such as Claude Code, OpenCode, and Pi. They also requested regular progress updates and urged the assistant to accelerate delivery through efficient parallel execution.
What Changed
fm_remote_job_stop_stray_linux_workersinbin/fm-remote-job-lib.shto stop existing worker supervisors before starting a new Linux remote worker whenworker.pidis stale.bin/fm-brief.shstatus protocol documentation and examples to consistently useneeds-decision [key=<slug>]:andresolved [key=<slug>]:formatting.Risk Assessment
✅ Low: The changes are well-bounded test reliability improvements and a targeted stray worker supervisor cleanup fix on Linux.
Testing
Executed all modified test scripts and related remote job, decision key, and runner verification suites. All tests passed, confirming that stray worker process groups are safely stopped before new launches, timeouts and orphan waits are bounded, pid tracking reaps cleanly, and brief decision-key placement renders as documented.
Evidence: Test Runner Execution Timing & Results
Source: Test Runner Execution Timing & Results
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
bin/fm-brief.sh- branch carries 1 commit(s) that exist on your local main branch but were never pushed to origin/main; rebasing would bundle this unrelated work (2 file(s)) into the PR:Push main to origin, or rebase your branch onto origin/main, before gating.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
./tests/fm-brief.test.sh./tests/fm-remote-job-orphan-reap.test.sh./tests/fm-afk-inject-herdr-e2e.test.sh./tests/fm-inactive-reconcile.test.sh./tests/fm-pr-check-security.test.sh./tests/fm-remote-reply.test.sh./tests/fm-remote-secondmate-lifecycle-e2e.test.sh./tests/fm-remote-job.test.sh./tests/fm-classify-decision-key.test.sh./tests/fm-send-resolve-key.test.sh./tests/fm-test-fixture-cleanup.test.sh./tests/fm-test-isolation-proof.test.sh./tests/fm-test-run.test.sh✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.