Repository navigation
fix(mqtt): wait up to 10 s for CONNACK - #143
Open
drronnie85 wants to merge 1 commit into
Open
drronnie85 wants to merge 1 commit into
drronnie85 wants to merge 1 commit into
Conversation
The connect wait was the same 2 s PubSubClient socket timeout used for reading packets. Brokers that check the password against another service, such as the Home Assistant Mosquitto add-on, can take longer than that to answer, so every attempt ended in a timeout (state -4) although the broker was up. AWTRIX 3 used PubSubClient's 15 s default and connected fine. The CONNACK wait is now 10 s; packet reads keep their 2 s timeout, so a stalled packet still cannot hold the loop for longer than before. An unreachable broker still fails on the TCP connect deadline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connect wait was the same 2 s PubSubClient socket timeout used for reading packets. Brokers that check the password against another service, such as the Home Assistant Mosquitto add-on, can take longer than that to answer, so every attempt ended in a timeout (state -4) although the broker was up. AWTRIX 3 used PubSubClient's 15 s default and connected fine.
The CONNACK wait is now 10 s; packet reads keep their 2 s timeout, so a stalled packet still cannot hold the loop for longer than before. An unreachable broker still fails on the TCP connect deadline.
What this changes
How it was verified
python scripts/test_native.pypassespio run -e awtrix,pio run -e awtrix_s3_octalandpio run -e awtrix_s3_quadbuildChecklist
test/, or it genuinely cannot run off-devicesrc/core/stayed portable (no Arduino, FastLED or board headers)docs/updated for any new field, endpoint or setting(see the table in CONTRIBUTING.md)