Skip to content

ci: add secret scanning (PF-1540) - #4

Merged
w0ofy merged 2 commits into
mainfrom
michaelwolf/pf-1540-security-checks
Nov 19, 2026
Merged

w0ofy merged 2 commits into
mainfrom
michaelwolf/pf-1540-security-checks

Conversation

@w0ofy

@w0ofy w0ofy commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

What

Adds .github/workflows/security-checks.yml, which scans every pull request and every push to main for committed secrets. Two scanners report as two checks:

Check Tool Catches
secrets-verified TruffleHog Credentials a provider confirms are live
secrets-patterns gitleaks CLI Known key formats and high-entropy strings

Why

PF-1540: every actively maintained repository gets a secret scan on every pull request. This repository did not have one.

Notes for the reviewer

  • Workflow file only; no other changes.
  • This repository is public, so it cannot call the org's shared workflow, which lives in a private repository. The file is a copy of that workflow with the same pinned versions, and has to be kept in step with it by hand.
  • The scan reads no secrets and needs only contents: read, so it also runs on pull requests from forks.
  • Runs scan the commits in the pull request or push, not the whole history. gitleaks output is redacted in the log.
  • If gitleaks raises a false alarm, add the finding's fingerprint to a .gitleaksignore at the repo root.
  • Not in this PR: making the two checks required in the repository ruleset. That should follow once this is merged.

Part of PF-1540

🤖 Generated with Claude Code

w0ofy and others added 2 commits November 17, 2026 20:21
Runs TruffleHog and the gitleaks CLI on every pull request and every
push to main, as two checks. A standalone copy of the org's shared
workflow, which a public repository cannot call.

Part of PF-1540

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Brings this copy in line with the shared workflow's three later changes:

- the checkout no longer fails on a broken submodule entry
- TruffleHog scans the checkout in place instead of copying it first
- gitleaks findings are annotated on their line in the pull request diff
- the step that explains a failed scan has a name, so a passing run no
  longer lists its message as a step

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@w0ofy
w0ofy merged commit 8490f5c into main Nov 19, 2026
3 checks passed
@w0ofy
w0ofy deleted the michaelwolf/pf-1540-security-checks branch November 19, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant