Gate FFmpeg library download to Windows x64 - #137
Draft
Blackspirits wants to merge 1 commit into
Draft
Blackspirits wants to merge 1 commit into
Blackspirits wants to merge 1 commit into
Conversation
Blackspirits
commented
Sep 15, 2026
Blackspirits
left a comment
Owner
Author
There was a problem hiding this comment.
Final adversarial review on 40a378520cf3c769c01b2ade05d9fc82f68b2cdc after CI SubtitleEdit#274: no blocker found. The Settings affordance and service URL selection now consume the same Windows-x64 capability contract; ARM64/x86 cannot be offered a guaranteed-failing action, while the service still fails closed if invoked directly. No merge/promotion performed.
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Independent platform-capability follow-up to #134 ("Pin and verify the FFmpeg shared-library archive").
#134 intentionally supports one reviewed native package: Windows x64. The service already rejected every other platform at runtime, but Settings exposed the action on every Windows process, including native Windows ARM64/x86 where it could only fail.
Current upstream
SubtitleEdit/subtitleeditmain was rechecked atd6917286e355976da953d0ee22208b4bf9461699; no relevant drift or open upstream PR was found.Finding fixed
Settings used
OperatingSystem.IsWindows()whileFfmpegLibsDownloadService.GetUrl()required Windows and process architecture x64. Windows ARM64/x86 therefore saw an action whose only outcome wasPlatformNotSupportedException.Fix
The service now owns one capability contract:
IsDownloadSupported(bool isWindows, Architecture processArchitecture);IsDownloadSupportedOnCurrentPlatform();GetUrl()uses that capability;IsFfmpegLibsDownloadVisible.Future platform support therefore changes from one contract rather than two independent conditions.
Regression coverage
The matrix pins:
Existing #134 URL/digest tests remain unchanged.
Scope / branch state
88f1405ec15e2b73d9192c0307cb2efc3da65d3e40a378520cf3c769c01b2ade05d9fc82f68b2cdcd6917286e355976da953d0ee22208b4bf9461699AI assistance: ChatGPT was used for platform-capability review, UI/service contract deduplication, upstream-conflict search and architecture-matrix regression design.
Final CI
Authoritative run: SubtitleEdit#274 on
40a378520cf3c769c01b2ade05d9fc82f68b2cdcFinal adversarial review was performed on this exact HEAD after CI; no blocker found.