Repository navigation
Make workflow captures verify the intended screen - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow captures had drifted: a file-plan-less completion became a needs-attention record, and a later running seed reused that terminal queue state. Captures named progress and completion could therefore show Setup or only a header while their tests passed.
Use fresh fixtures for each state, grounded scratch copies/digests and the recorded selected-file plan. Always-on assertions check the queue route and verdict. Opt-in captures separately name the workbench and actual production progress/outcome components; OCR checks those expanded components for their expected content and controls. Mac capture compositing keeps the native buttons readable, and fixture cleanup restores window preferences and removes its isolated settings domain.
Test-only changes; no app behavior or verification policy changes. These remain seeded layout/route checks, not an interactive transfer or physical-device walkthrough. The seeded percentage does not test progress arithmetic.
Local results, captures enabled: Mac focused suite 6 passed, iPhone focused suite 10 passed, complete iPad target 75 passed; zero failures or skips. Actual images inspected on all three layouts. Independent review identified two preference leaks; both are corrected and the final Mac run passed afterward.
git diff --checkis clean.