Repository navigation
Reject contradictory digests in legacy verification reports - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A legacy report could name Standard, Thorough or Paranoid and bypass validation of its supplied digest list. For example,
standardwithROT13could be shown as verified. The reader now rejects unsupported, malformed or contradictory supplied algorithms before classifying the evidence.Genuine older reports with no algorithm remain readable. Generic checksum and byte-comparison records still avoid claiming a selected transfer mode they never recorded. Current writer outputs retain their existing behavior.
The decisive regression fails on unchanged main, and engine compatibility tests plus Mac report-scanner tests cover the corrected rules. This changes evidence interpretation only; copying, destination readback and the verification defaults are unchanged.
Local gates: engine XCTest 183 tests (20 expected skips), Swift Testing 216 tests across 38 suites; Mac 1,238 passed with 14 expected skips; universal iPhone/iPad simulator build succeeded. No failures in these gates. Independent review found no remaining defect in the delta. CI is not used as a gate because the account's minutes are exhausted.