Repository navigation
Bound camera XML metadata reads - #44
Merged
Merged
Conversation
mikecerisano
force-pushed
the
fix/xml-metadata-bounds-20261017
branch
from
October 17, 2026 15:00
6f6271e to
0561355
Compare
mikecerisano
force-pushed
the
fix/xml-metadata-bounds-20261017
branch
from
October 17, 2026 15:13
0561355 to
de8c27d
Compare
mikecerisano
marked this pull request as ready for review
October 17, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A card with a large XML sidecar could make the optional camera-name detector load and search the whole file. It now inspects only regular, non-symlink XML files up to 4 MiB and skips larger files entirely. Each candidate uses a bounded descriptor read and its own autorelease pool; cancellation is checked through the read and pattern search. Named
.xmlfiles are parsed once.This changes only advisory camera naming. Transfer, verification, reports, and safety verdicts are untouched.
Local validation:
./test.sh mac-test): 1,174 total; 1,161 passed, 13 skipped, zero failed, no test-host restart.git diff --check: clean. Rebasing onto the latest main changed no patch content.An earlier broader Xcode command omitted the repository's
-only-testing:BitMatchTestsfilter and launchedBitMatchUITests-Runner, which was killed before bootstrapping. The exact repository gate above completed successfully; this branch does not change UI tests.