Repository navigation
Show when backup drive separation is unknown - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When BitMatch cannot resolve a destination's physical drive identity, the existing policy still counts that destination as another backup. Setup now distinguishes selected destination folders from that policy count and quietly says “Separate storage isn't confirmed” when the current selection's physical separation is unknown. This matters on iPhone and iPad file-provider destinations, where an identity may be unavailable.
Queued cards keep their destination folders but do not save a physical-drive assessment. Setup therefore shows the same one-line uncertainty note when any staged card has multiple destinations, even if those folders may later prove to be on distinct drives. That is deliberately cautious until there is a persisted assessment. The Project gate, transfer verdict, History, and reports are unchanged; the broader physical-independence policy remains a separate decision.
Local validation: focused engine identity-policy tests passed (4/4). The Mac app test target ran 266 XCTest cases (12 expected skips) and 866 Swift Testing cases in 88 suites, with zero failures. The iOS Simulator Debug build succeeded. The opt-in staged-Setup screenshot test passed on an iPhone 17 Pro simulator; its full-height iPhone and iPad-size captures were visually reviewed, with the note on one muted line and no clipping. Earlier validation of the combined draft branch also passed the full engine and Mac suites, both mobile simulator suites (65 Swift Testing cases each), and Mac/iOS Release builds. A physical file provider has not been tested, so this does not claim to prove drive independence.
On earlier draft pushes, GitHub Actions Mac jobs stopped before tests during an Xcode 26.3 compiler IR-generation crash in
PreferencesWindow.swift; engine jobs stopped before tests on Swift concurrency compile errors inChecksumTruncationTests.swiftandStressTests.swift. Those compile failures also appeared on the existing #28 CI branch. Evidence-corpus jobs passed. The local results above are the review evidence for this draft.