Repository navigation
Keep file handling in Settings and add optional transfer details - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppleDouble handling now lives in Settings → File handling instead of the transfer window. Recognized companions are ignored when no preference has been saved; saved choices and queued transfer policies are retained. Other hidden files and camera sidecars are preserved. Setup shows only a nonzero exclusion count, with the review list tucked into Settings. Analysis failures still block Start.
Advanced → Transfer details adds optional operator and notes, collapsed by default. Values are remembered until cleared, snapshotted per queued card, and included in automatic/History PDF, CSV, JSON and ASC MHL. Old settings decode without losing their values, MHL comments escape user text, and details never enter diagnostic logs.
Expanded testing exposed two PDF presentation defects: intentional exclusions were also counted as file errors, and long multiline notes left excess space on the first page. Both were reproduced with failing regressions and fixed locally in report presentation. Exclusions remain explicit, selected files stay independently verified, and the whole-card verdict stays unsafe when files were omitted.
Local validation:
Physical-device picker/keyboard/share workflows and real USB/dock disconnects are not simulated by these checks. Earlier failed runs and corrected test assumptions remain documented in docs/TRANSFER_DETAILS_VALIDATION.md; final gates are green. PR #18 (PDF thumbnails) is already merged.