fix(ci): stop overwriting checksum-verified gitleaks with an unverified download - #589
Merged
Merged
Conversation
…ed download The secret-scan job downloaded and sha256-verified gitleaks 8.30.1, then immediately re-downloaded 8.30.0 via a plain `curl | tar` pipe with no checksum, silently overwriting the verified binary. The binary actually executed was never the one the checksum covered -- the verification step was dead weight, and the job was exposed to exactly the unverified-download risk issue #424 originally flagged. Drop the redundant unverified re-download; keep only the checksummed 8.30.1 install (checksum independently re-verified against the current upstream release before this change). Fixes #586, closes the last open half of #424.
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
secret-scanjob's "Install gitleaks" step downloaded and sha256-verifiedgitleaks 8.30.1, then immediately re-downloaded 8.30.0 through a plain
curl | tarpipe with no checksum, overwriting the just-verified binary at/usr/local/bin/gitleaks. The scanner that actually ran on every PR was neverthe checksummed artifact -- the verification step was dead weight, and the
gate carried exactly the unverified-supply-chain risk issue #424 flagged
against the original
releases/latestinstall.Found by independent audit of PR #585 (which fixed the all-ref scan-scope bug
but didn't touch this).
Fix
Delete the redundant unverified re-download. Keep only the checksummed 8.30.1
install; independently re-verified its sha256 against the current upstream
release before merging (matches the pinned hash).
Verification
sha256summatches the pinned551f6fc8...exactly.introduced.
Fixes #586, closes the last open half of #424.