Repository navigation
bootloader: reject empty stage1 signatures - #2207
Open
benma-agent wants to merge 1 commit into
Open
benma-agent wants to merge 1 commit into
benma-agent wants to merge 1 commit into
Conversation
PUKCC verification rejects all-zero signatures on the current hardware, but stage0 should not rely on that behavior to exclude empty signature slots from its signing threshold. Make the rejection explicit so it remains robust against changes to the chip or verifier implementation. Require a nonzero signature as well as a successful PUKCC result before counting a slot. Scan every byte through volatile reads independently in both passes, retaining the six PUKCC calls and the existing threshold and mask consistency checks. Behavior on the current hardware is unchanged, including acceptance of two valid signatures with an empty third slot.
benma
marked this pull request as ready for review
November 17, 2026 08:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PUKCC verification rejects all-zero signatures on the current hardware, but
stage0 should not rely on that behavior to exclude empty signature slots from
its signing threshold. Make the rejection explicit so it remains robust
against changes to the chip or verifier implementation.
Require a nonzero signature as well as a successful PUKCC result before
counting a slot. Scan every byte through volatile reads independently in both
passes, retaining the six PUKCC calls and the existing threshold and mask
consistency checks. Behavior on the current hardware is unchanged, including
acceptance of two valid signatures with an empty third slot.