Skip to content

bootloader: reject empty stage1 signatures - #2207

Open
benma-agent wants to merge 1 commit into
BitBoxSwiss:masterfrom
benma-agent:benma-agent/stage0-reject-zero-signatures
Open

benma-agent wants to merge 1 commit into
BitBoxSwiss:masterfrom
benma-agent:benma-agent/stage0-reject-zero-signatures

Conversation

@benma-agent

Copy link
Copy Markdown
Contributor

PUKCC verification rejects all-zero signatures on the current hardware, but
stage0 should not rely on that behavior to exclude empty signature slots from
its signing threshold. Make the rejection explicit so it remains robust
against changes to the chip or verifier implementation.

Require a nonzero signature as well as a successful PUKCC result before
counting a slot. Scan every byte through volatile reads independently in both
passes, retaining the six PUKCC calls and the existing threshold and mask
consistency checks. Behavior on the current hardware is unchanged, including
acceptance of two valid signatures with an empty third slot.

PUKCC verification rejects all-zero signatures on the current hardware, but
stage0 should not rely on that behavior to exclude empty signature slots from
its signing threshold. Make the rejection explicit so it remains robust
against changes to the chip or verifier implementation.

Require a nonzero signature as well as a successful PUKCC result before
counting a slot. Scan every byte through volatile reads independently in both
passes, retaining the six PUKCC calls and the existing threshold and mask
consistency checks. Behavior on the current hardware is unchanged, including
acceptance of two valid signatures with an empty third slot.
@benma
benma requested a review from NickeZ November 17, 2026 08:48
@benma
benma marked this pull request as ready for review November 17, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant