Repository navigation
rust: reject non-contributory Noise DH - #2199
Merged
benma merged 1 commit intoNov 12, 2026
Merged
Conversation
benma
marked this pull request as ready for review
November 10, 2026 11:41
Low-order X25519 public keys yield an all-zero shared secret. Accepting them lets a host complete Noise XX with a static identity that proves no private-key possession. Once approved, that identity can be reused to skip pairing verification. Reject non-contributory DH results before they enter the Noise key schedule. This also rejects previously remembered weak identities before the remembered-host lookup. Reset the Noise state on response-writing errors as well as read errors. The new DH failure can occur while writing the responder's first message; retaining that partially advanced state would allow further handshake processing after rejection.
benma-agent
force-pushed
the
benma-agent/noise-contributory-check
branch
from
November 11, 2026 15:20
2e56f7a to
7f0dde2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low-order X25519 public keys yield an all-zero shared secret. Accepting
them lets a host complete Noise XX with a static identity that proves no
private-key possession. Once approved, that identity can be reused to
skip pairing verification.
Reject non-contributory DH results before they enter the Noise key
schedule. This also rejects previously remembered weak identities
before the remembered-host lookup.
Reset the Noise state on response-writing errors as well as read errors.
The new DH failure can occur while writing the responder's first message;
retaining that partially advanced state would allow further handshake
processing after rejection.