Skip to content

i18n: add missing passphrase on host translations - #2195

Merged
benma merged 1 commit into
BitBoxSwiss:masterfrom
sutterseba:translate-passphrase-on-host
Nov 12, 2026
Merged

benma merged 1 commit into
BitBoxSwiss:masterfrom
sutterseba:translate-passphrase-on-host

Conversation

@sutterseba

Copy link
Copy Markdown
Collaborator

No description provided.

return Ok(passphrase);
}
hal.ui().status("Please try again", false).await;
let status = crate::tr!(hal, "Please try again");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between crate::tr!() and hal.tr()?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crate::tr!() throws an error during compilation if the source string is missing from the English lang file. hal.tr() just falls back to the supplied text.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Made a PR to your PR to use tr!() so we can have static checks: sutterseba#2

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent PR on master to enforce static checks everywhere (except in C)

#2198

@sutterseba
sutterseba force-pushed the translate-passphrase-on-host branch from fb645fc to 881e31a Compare November 11, 2026 15:32

@benma benma left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

edit: I squashed the two commits

Passphrase on host related translations were missing.

Existing translation for "Please try again" was bypassed in unlock.rs,
fixed as well.
@benma
benma force-pushed the translate-passphrase-on-host branch from 881e31a to 3ba5f42 Compare November 12, 2026 08:21
@benma
benma merged commit 4dfa26b into BitBoxSwiss:master Nov 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants