Repository navigation
i18n: add missing passphrase on host translations - #2195
Merged
benma merged 1 commit intoNov 12, 2026
Merged
Conversation
benma
reviewed
Nov 9, 2026
| return Ok(passphrase); | ||
| } | ||
| hal.ui().status("Please try again", false).await; | ||
| let status = crate::tr!(hal, "Please try again"); |
Collaborator
There was a problem hiding this comment.
What's the difference between crate::tr!() and hal.tr()?
Collaborator
Author
There was a problem hiding this comment.
crate::tr!() throws an error during compilation if the source string is missing from the English lang file. hal.tr() just falls back to the supplied text.
Collaborator
There was a problem hiding this comment.
Thanks. Made a PR to your PR to use tr!() so we can have static checks: sutterseba#2
Collaborator
There was a problem hiding this comment.
Independent PR on master to enforce static checks everywhere (except in C)
sutterseba
force-pushed
the
translate-passphrase-on-host
branch
from
November 11, 2026 15:32
fb645fc to
881e31a
Compare
benma
approved these changes
Nov 12, 2026
Passphrase on host related translations were missing. Existing translation for "Please try again" was bypassed in unlock.rs, fixed as well.
benma
force-pushed
the
translate-passphrase-on-host
branch
from
November 12, 2026 08:21
881e31a to
3ba5f42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.