Repository navigation
Fixes eachoverlap(stream, collection) iterating forever - #52
Merged
Merged
Conversation
The iteration took the next query from the stream at a state that it didn't advance: a query whose group the collection lacked was taken again forever, and after a query without overlaps, a recursive search to the end of the stream was followed by another from the query, so that the rest of the stream was searched again for every such query. It now takes the queries in a loop that advances the stream's state with each one. The tests check a query whose group the collection lacks and queries without overlaps, which never ended before, and the pairs of a stream and a collection against those of two streams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
eachoverlap(stream, collection)iterating forever, and releases 3.0.1.iteratedidn't always advance the stream: a query whose group the collection lacks was retried forever, and a query without overlaps restarted the search from that query. It now advances the stream with every query.Results are unchanged.
New tests cover both cases, and cross-check stream–collection pairs against
simple_intersection.They hang without the fix and pass with it.
The "Run Benchmarks" failure is unrelated: it fails on every push, including 3.0.0's
master.