Draft
Add generic type parameters to Job class hierarchy for type-safe job arguments#107
Conversation
Co-authored-by: Billos <5809662+Billos@users.noreply.github.com>
…rguments Co-authored-by: Billos <5809662+Billos@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Billos
August 30, 2026 06:27
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jobs previously lacked compile-time type safety for their run method arguments. This PR introduces generic type parameters across the job hierarchy, enabling strongly-typed job implementations without sacrificing backward compatibility.
Changes
Base infrastructure
<TArgs = unknown>generic parameter toBaseJobabstract classSimpleJob,TransactionJob,BudgetJob, andEndpointJobwith sensible defaults matching their expected signaturesConcrete implementations
SetBudgetJobData,UpdateBillsBudgetLimitJobArgs)Queue/worker compatibility
queueArgs.tsto work with genericBaseJob<unknown>Example
Before:
After:
All 77 tests passing.