Skip to content

fix: defer checks from read-only investigation - #41

Merged
loadinglucian merged 2 commits into
mainfrom
fix/investigation-check-boundary
Jul 29, 2026
Merged

fix: defer checks from read-only investigation#41
loadinglucian merged 2 commits into
mainfrom
fix/investigation-check-boundary

Conversation

@loadinglucian

@loadinglucian loadinglucian commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • declare downstream check execution as an investigation non-goal
  • prevent read-only investigation from rerunning writable exact-head validation
  • add regression coverage for the phase boundary

Verification

  • ./scripts/test.sh
  • shellcheck scripts/*.sh
  • cross-repository A00-A20 verifier

Summary by CodeRabbit

  • Documentation

    • Clarified that required checks are verified during the downstream merge-readiness stage rather than during investigation.
    • Updated maintenance guidance to distinguish planned checks from checks that have already run.
  • Chores

    • Refined the maintenance workflow to reflect the updated investigation boundaries.
  • Tests

    • Added coverage to ensure the documented workflow and check-handling behavior remain consistent.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@loadinglucian, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 137fa195-e6c0-4dff-bdb5-f07da555dcd6

📥 Commits

Reviewing files that changed from the base of the PR and between c947c82 and 218bf8b.

📒 Files selected for processing (1)
  • tests/test_maintenance.py
📝 Walkthrough

Walkthrough

The investigation contract now treats requiredChecks as downstream exact-head gates. Documentation, workflow arguments, and unit tests ensure investigation declares but does not execute these checks.

Changes

Required check deferral

Layer / File(s) Summary
Investigation contract and validation
.github/codex/maintenance/investigation.md, .github/workflows/maintenance-watch.yml, tests/test_maintenance.py
The investigation documentation excludes required check execution, the workflow passes --non-goal required_check_execution, and a unit test verifies both changes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the main change: deferring checks during read-only investigation.
Description check ✅ Passed The description covers Summary and Verification well and is mostly aligned with the template, though Security and licensing is omitted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/investigation-check-boundary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@loadinglucian
loadinglucian merged commit a77ba2f into main Jul 29, 2026
2 of 3 checks passed
@loadinglucian
loadinglucian deleted the fix/investigation-check-boundary branch July 29, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant