fix: publish automation PR statuses - #38
Conversation
📝 WalkthroughWalkthroughThe maintenance check dispatcher now publishes successful per-validator commit statuses for the exact PR head SHA, using validator names and URLs. Three maintenance workflows grant ChangesMaintenance status publication
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/test_maintenance.py (1)
289-301: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winAssert the status payload and success-path ordering, not only substrings.
These checks can pass even if the dispatcher uses the wrong
state,context, ortarget_url, or publishes statuses before both validators pass. Add assertions covering the success payload fields and their placement after bothpublish_gatecalls.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/test_maintenance.py` around lines 289 - 301, Strengthen the maintenance workflow tests around the dispatcher assertions by verifying the success status payload uses the expected state, context, and target_url values. Also assert that the status publication occurs only after both validator publish_gate calls, preserving the required success-path ordering rather than relying solely on substring checks.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@tests/test_maintenance.py`:
- Around line 289-301: Strengthen the maintenance workflow tests around the
dispatcher assertions by verifying the success status payload uses the expected
state, context, and target_url values. Also assert that the status publication
occurs only after both validator publish_gate calls, preserving the required
success-path ordering rather than relying solely on substring checks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c570d3c6-3be6-4380-b972-c4c17a0a7a73
📒 Files selected for processing (6)
.github/workflows/maintenance-implementation.yml.github/workflows/maintenance-release.yml.github/workflows/maintenance-watch.ymldocs/repository-settings.mdscripts/dispatch-pr-checkstests/test_maintenance.py
Adds GitHub commit statuses for the required contexts only after the exact-head dispatched CI and Protected controls validators pass. Retains the Actions check-run evidence and validator URLs, then waits for the PR rollup before ordinary merge.\n\nVerified: php-bin 18 tests; cross-repository A00-A20 digest sha256:965a10409c051cf22d6864c86c91e6ca58c440779c5690d37e1098a758fee568.
Summary by CodeRabbit
Enhancements
Documentation
Reliability