Repository navigation
Conversation
BigPizzaV3
requested changes
Oct 13, 2026
BigPizzaV3
left a comment
Owner
There was a problem hiding this comment.
审查结论:Request changes。
[P1] 持久化的失效会话列表没有恢复到用于渲染隐藏状态的 verifiedInvalidSessionIds。
代码在启动时从 localStorage 恢复 invalidSessionIds(60-plugin-marketplace.js:663-664),但 applyInvalidSessionVisibility() 只检查 verifiedInvalidSessionIds(680-684)。因此用户完成一次“检查并隐藏”后,重载页面不会立即隐藏已确认失效的会话,要等自动复查(最长约 5 分钟)后才恢复。
请在恢复持久化状态时同步 verifiedInvalidSessionIds,或调整状态模型保证重载后立即符合持久化契约,并补一条页面重载回归测试。修复后请补跑 Windows artifacts 和 macOS DMG CI。
Author
|
已按 review 修复,当前 head 为
完整构建结果: 上游自动 |
nk33-dev
force-pushed
the
codex/session-health
branch
from
October 14, 2026 01:36
61731f7 to
e05d578
Compare
Author
|
已将当前 PR 迁移到 Codex++ 1.8.0 最新 main 保留上游实时用量路由并合入会话健康路由;页面重载隐藏回归通过。 上游自动 workflow 仍需维护者批准;以上是同一 workflow 对当前 head 的手动 dispatch 结果。 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
本机会话记录和侧栏索引仍存在、但 rollout 与恢复来源均已丢失时,列表继续显示无法打开的会话。直接删除有误删风险,尤其是远端会话、刚创建尚未落盘的会话和可以从归档或备份恢复的会话。
改动
thread/read确认不存在;隐藏前再次复核恢复来源,检查期间恢复的会话继续显示。此 PR 不提供永久删除、备份恢复或自动清空会话,也不保证清除所有侧栏残留。原生接口或数据来源无法完整确认时保留会话。
验证
基于上游
45f1c151,Windows 隔离 worktree:cargo test -p codex-plus-data --test session_health -p codex-plus-launcher --lib --locked --offline:Data lib 152 passed / 2 项既有 ignored;健康检查 11 passed;Launcher lib 32 passed。cargo test -p codex-plus-core --test bridge_routes --locked --offline:36 passed。npm test:561 passed,1 项既有 skipped。cargo check --workspace --locked --offline、npm run check、npm run vite:build、renderer 组装一致性及git diff --check HEAD通过。未运行完整工作区测试和 clippy,也未进行真实桌面宿主和 macOS/Linux 原生验证。上游已有全仓格式差异,此 PR 保留相关文件的现有格式。测试仅使用临时数据库与 mock RPC,未操作真实用户会话。