Repository navigation
Conversation
Owner
|
当前 PR 没有任何可用的 CI check。请补跑 Windows artifacts 和 macOS DMG CI 后再继续审核。该改动涉及 SQLite WAL、会话索引缓存、数据库替换和分页一致性,建议至少覆盖这些路径的回归测试。 |
Author
|
已按要求对当前 head 本次全量测试同时覆盖了 SQLite WAL 提交/截断/复用、索引缓存复用、同尺寸同时间戳数据库替换、并发快照,以及去重后的深分页一致性。上游自动 |
nk33-dev
force-pushed
the
codex/session-paging
branch
from
October 14, 2026 01:36
09627fe to
650169a
Compare
Author
|
已将当前 PR 迁移到 Codex++ 1.8.0 最新 main 会话分页与 SQLite WAL、索引缓存、数据库替换回归通过。 上游自动 workflow 仍需维护者批准;以上是同一 workflow 对当前 head 的手动 dispatch 结果。 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
本地会话列表每次翻页都会枚举全部 ID,再从每个数据库读取
offset + limit + 1条完整记录,合并去重后才截取本页。历史较多时,深分页反复读取前面的标题和路径;查询也直接占用管理器命令线程。改动
offset、limit、hasMore、totalCount接口。spawn_blocking。单库失败返回错误及健康库结果,不把旧缓存当成成功结果。首次读取及缓存失效仍需建立轻量索引,内存随会话数增长。多个数据库没有共同事务快照,外部写入期间不保证多次翻页冻结。此 PR 不改会话删除、供应商同步或列表界面。
验证
基于上游
45f1c151,Windows 本地隔离 worktree:cargo test -p codex-plus-data --locked --offline --no-fail-fast:254 passed,2 项既有 ignored。cargo test -p codex-plus-manager --lib local_sessions --locked --offline:3 passed。npm test:548 passed,1 项既有 skipped。Git Bash 加入当前进程 PATH 后通过。npm run check、npm run vite:build、git diff --check HEAD通过。cargo fmt --all --check被上游既有格式差异阻断,本 PR 保持相关文件原有风格。没有进行真实用户数据库上的性能计时、实际桌面启动或 macOS/Linux 原生运行验证。自动测试使用临时数据库,未修改正在使用的会话数据。