Repository navigation
fix(payments): branded empty state for invalid/expired payment links (#741) - #867
Merged
therealjhay merged 1 commit intoSep 29, 2026
Merged
Conversation
…etta-Pay#741) Resolving a payment link previously threw on null data or surfaced a raw error boundary, leaving payers stranded on a broken page. The pay page now resolves the link first and renders InvalidPaymentLinkState for 404/410/403 responses, with reason-specific copy, a support reference for the link id, and retry only for transient failures. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@michealross Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@michealross is attempting to deploy a commit to the therealjhay's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made:
InvalidPaymentLinkState(new): Branded empty state for links that can't be fulfilled, with reason-specific copy fornot-found,expired, anderror, a support reference showing the unresolved link id, and a BettaPay brand mark.app/pay/[linkId]/page.tsx: Resolves the link viaGET /api/payment-links/:linkIdbefore rendering the form (loading → ready/invalid state machine). Maps 410 → expired, 404/403 → not-found, everything else → error with a "Try again" action that re-runs resolution. Invalid links never render the payment form or throw.Verification:
npx jest— 17/17 passing across both new suites.npm run typecheck— no errors in the changed files (remaining errors are pre-existing in unrelated files).