fix: enforce LiteAdmin MCP route permissions by tin-berri · Pull Request #48080 · BerriAI/litellm

tin-berri · 2026-10-23T19:13:11Z

This aligns management checks with the gateway’s existing access rules and improves compatibility across supported environments. Focused regression coverage keeps request handling and access isolation consistent.

Details

Changes

Use registered routes and shared authorization checks
Clarify the request-handling contract
Improve optional-dependency and Python compatibility
Keep generated API types synchronized

Verification

89 focused management tests pass locally
make check passes
Three deliberate mutations are caught by the regression tests
Older supported Python versions skip connector-dependent cases correctly
Fresh CI and bot reviews are running for f5080d7bcdba619f3adec0c65d34b90f2e156be2

Live verification

Before/after checks used real local services and isolated test data. The recording at 73eae699ee0a3cb399fdaf7e404ed5953847a77a remains applicable to the current tip because the follow-up changes documentation and tests only

mcp-feature.mp4

Limitations

Hosted-mount verification was blocked by the available enterprise license
The standalone connector flow was verified
Existing connector restrictions on resource identifiers remain

Pre-submission checklist

Focused tests and local quality checks pass
Live verification completed for the affected flow
CI passes on the latest commit
Latest automated reviews are complete and addressed

codecov · 2026-10-23T19:18:20Z

Codecov Report

❌ Patch coverage is 97.29730% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
litellm/proxy/admin_mcp.py	96.66%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

codspeed · 2026-10-23T19:22:12Z

Merging this PR will not alter performance

1 warning

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 38 untouched benchmarks
🆕 4 new benchmarks

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
🆕	`test_pdf_page_of_drawing_operators_and_no_image`	N/A	23.3 ms	N/A
🆕	`test_pdf_page_of_forms_sharing_one_resources_dictionary`	N/A	19.7 ms	N/A
🆕	`test_pdf_page_of_parent_forms_sharing_one_child_form`	N/A	305.6 ms	N/A
🆕	`test_token_counter_long_unknown_model_name`	N/A	2.2 ms	N/A

_{Comparing litellm_mcp_key_authorization (f5080d7) with main (24afa12)¹}

No successful run was found on main (e0778bc) during the generation of this report, so 24afa12 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

tin-berri · 2026-10-23T20:11:11Z

@greptileai

tin-berri · 2026-10-23T20:11:13Z

bugbot run

cursor · 2026-10-23T20:11:15Z

Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository.

…mcp_permissions (HW-217) Upstream 31fb096 requires /user/info?admin_mcp=true to return admin_mcp_permissions, which no LiteLLM release ships yet (BerriAI/litellm#48080 open). Opt-in keeps the proxy_admin check and shows every tool; gateways that return the field are still enforced. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WL1AnKCfSVBCpVhFti8G46

tin-berri · 2026-10-29T19:42:28Z

@greptileai

Please review the latest commit after merging main and resolving the lockfile conflict while preserving the LiteAdmin MCP dependency pin

tin-berri · 2026-10-29T19:42:29Z

bugbot run

Please review the latest commit after merging main and resolving the lockfile conflict while preserving the LiteAdmin MCP dependency pin

greptile-apps · 2026-10-29T19:46:04Z

Confidence Score: 5/5

[Medium impact] The latest test-only changes appear safe to merge

Summary

The PR makes Admin MCP permissions follow the caller's HTTP route grants. The latest commit simplifies test setup without changing production behavior

Admin MCP permissions follow the caller’s registered management routes.
The Rust beta mapping no longer lists Databricks for this Anthropic beta.

_{Reviews (5) · Last reviewed commit: "test(admin-mcp): simplify HTTP permissio..." · Reviewed by Greptile}

cursor

Stale Bugbot comment from a previous run.

tin-berri · 2026-10-29T21:43:51Z

@greptileai

Please review commit 45fb345, including permission matching, older Python guards, and live proof. Local checks pass; CI is running

tin-berri · 2026-10-29T21:43:52Z

bugbot run

Please review commit 45fb345 after the authorization fixes. Local checks pass, and the PR contains real before-and-after evidence

cursor

Stale Bugbot comment from a previous run.

tin-berri · 2026-10-29T22:00:35Z

@greptileai

Please review 73eae69, including the Databricks call-path evidence. Live MCP proof is refreshed; local checks pass and CI is running

tin-berri · 2026-10-29T22:00:37Z

bugbot run

Please review 73eae69 after merging main. Authorization code is unchanged from your clean review; live proof and local checks pass

cursor

Stale Bugbot comment from a previous run.

tin-berri · 2026-10-30T01:35:19Z

bugbot run

Please review 35212f2 and the HTTP regression covering nested encoding. Removing decoding, double decoding, and plus conversion each fail

tin-berri · 2026-10-30T01:35:21Z

@greptileai

Please review 35212f2. Added real HTTP regressions and clarified path encoding. All 89 admin MCP tests and make check pass

cursor

Stale Bugbot comment from a previous run.

tin-berri · 2026-10-30T01:43:49Z

bugbot run

Please review f5080d7, including the focused HTTP encoding regression. Missing decoding, double decoding, and plus conversion all fail the tests

tin-berri · 2026-10-30T01:43:50Z

@greptileai

Please review f5080d7. Simplified regression scaffolding while retaining all eight encoding cases. All 89 admin tests and local quality gates pass

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit f5080d7. Configure here.}

fix(admin-mcp): expose and enforce credential route permissions

a298cb0

tin-berri requested a review from a team October 23, 2026 19:13

tin-berri mentioned this pull request Oct 23, 2026

fix: update LiteAdmin MCP integration BerriAI/liteadmin-mcp#4

Merged

tin-berri changed the title ~~fix(admin-mcp): enforce credential route permissions~~ fix: update LiteAdmin MCP integration Oct 23, 2026

mateo-berri mentioned this pull request Oct 29, 2026

feat(auth): sign in through the gateway in the browser when no admin key is set BerriAI/liteadmin-mcp#5

Open

1 task done

chore: merge main and resolve MCP dependency lock conflict

bb015b4

greptile-apps Bot reviewed Oct 29, 2026

View reviewed changes

Comment thread tests/unit/proxy/test_admin_mcp.py

Comment thread litellm/proxy/admin_mcp.py Outdated

cursor Bot reviewed Oct 29, 2026

View reviewed changes

Comment thread litellm/proxy/admin_mcp.py Outdated

Comment thread litellm/proxy/admin_mcp.py Outdated

tin-berri added 2 commits October 29, 2026 14:19

fix: restore beta header and telemetry test parity

a5ee74d

fix(admin-mcp): align permissions with registered HTTP routes

45fb345

tin-berri changed the title ~~fix: update LiteAdmin MCP integration~~ fix: enforce LiteAdmin MCP route permissions Oct 29, 2026

greptile-apps Bot reviewed Oct 29, 2026

View reviewed changes

Comment thread litellm-rust/crates/llms-types/src/providers/anthropic/beta.rs

cursor Bot reviewed Oct 29, 2026

View reviewed changes

chore: merge main and retain upstream telemetry tests

73eae69

cursor Bot reviewed Oct 29, 2026

View reviewed changes

Comment thread litellm/proxy/admin_mcp.py

test(admin-mcp): verify encoded paths through HTTP authorization

35212f2

cursor Bot reviewed Oct 30, 2026

View reviewed changes

test(admin-mcp): simplify HTTP permission regression fixtures

f5080d7

moe-berri approved these changes Oct 30, 2026

View reviewed changes

cursor Bot reviewed Oct 30, 2026

View reviewed changes

tin-berri enabled auto-merge (squash) October 30, 2026 01:48

tin-berri merged commit fd594ab into main Oct 30, 2026
118 checks passed

tin-berri deleted the litellm_mcp_key_authorization branch October 30, 2026 02:00

mateo-berri mentioned this pull request Oct 30, 2026

fix(vertex_ai,azure_ai)!: auto-add the compaction, thinking display, and tool change betas on Claude routes #44747

Open

7 of 8 tasks

Conversation

tin-berri commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Verification

Live verification

Limitations

Pre-submission checklist

Uh oh!

codecov Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Performance Changes

Footnotes

Uh oh!

tin-berri commented Oct 23, 2026

Uh oh!

tin-berri commented Oct 23, 2026

Uh oh!

cursor Bot commented Oct 23, 2026

Uh oh!

tin-berri commented Oct 29, 2026

Uh oh!

tin-berri commented Oct 29, 2026

Uh oh!

greptile-apps Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tin-berri commented Oct 29, 2026

Uh oh!

tin-berri commented Oct 29, 2026

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tin-berri commented Oct 29, 2026

Uh oh!

tin-berri commented Oct 29, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tin-berri commented Oct 30, 2026

Uh oh!

tin-berri commented Oct 30, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tin-berri commented Oct 30, 2026

Uh oh!

tin-berri commented Oct 30, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

tin-berri commented Oct 23, 2026 •

edited

Loading

codecov Bot commented Oct 23, 2026 •

edited

Loading

codspeed Bot commented Oct 23, 2026 •

edited

Loading

greptile-apps Bot commented Oct 29, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading