Repository navigation
Contain Slack adapters and compose event sources - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack helpers still appeared beside the Slack package after the first refactor, and Socket Mode was coupled to the adapter. This change removes the sibling compatibility files and composes Slack with a replaceable event source.
channels/slack/; the shared channel root contains only contracts.SlackEventSourceandSocketMode. Applications can inject authenticated events without duplicating parsing, subscriptions, history, replies, files, or status behavior. ExistingSlack(bot_token=..., app_token=...)setup continues to use Socket Mode.Import migration:
from agentchat.channels import Slack, SlackUserbecomesfrom agentchat.channels.slack import Slack, SlackUser. The oldslack_files,slack_media, andslack_mirrormodules are removed; canonical replacements are listed indocs/architecture.md.Validation: 212 tests passed in the checkout and again against an installed wheel using the source archive's tests; Ruff,
git diff --check, anduv buildpassed. Verified that a deliberately misplaced file fails the architecture test and that the wheel/source archive contain no removed shims. Verified against currentmainwith no conflicts. GitHub Actions also passed lint and the full suite on Python 3.11. Live Slack credentials were not used.