issue #326: Promote char_{min,max}_wrapper helpers to module scope#327
Merged
Conversation
bonachea
commented
May 20, 2026
Member
Author
bonachea
left a comment
bonachea
left a comment
There was a problem hiding this comment.
Rename to ensure all non-PRIF global symbols have a caf_ prefix, as required in our coding conventions
…le scope F2023 C1807 states: > A procedure defined in a submodule shall not have a binding label > unless its interface is declared in the ancestor module. Promoting helper procedures like these to PRIF module scope would be tedious and break abstraction boundaries, so instead declare a single-purpose module to hold each helper procedure.
Member
Author
|
Squashed down to a single commit, to simplify cherry-pick against older releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #326