Repository navigation
fix: should warn npcap installation on windows. - #1
Merged
Merged
Conversation
BeiChenStanly
changed the title
BeiChenStanly
changed the title
BeiChenStanly
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the developer/user experience around the embedded EasyTier component by adding an early failure hint for common Windows dependency issues (Npcap/packet.dll), and by adjusting how the EasyTier release archive is sourced and repackaged during build.
Changes:
- Add a short post-spawn health check in
EasyTier::start()to detect immediate exits and log actionable Windows/Npcap guidance. - Enhance
build.rsto optionally use a locally provided EasyTier zip and to repack zip contents by iterating archive entries. - Add a
rust-toolchainfile to standardize builds on the stable Rust toolchain.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/easytier.rs | Adds an early “exited immediately” health check and logs Windows/Npcap guidance when EasyTier fails to start. |
| build.rs | Adds support for using a local EasyTier zip and changes repackaging to iterate over zip entries. |
| rust-toolchain | Pins the project to the stable Rust toolchain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.