Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Backwards compatibility with Python 2.7 and unicode? #94

Description

@dr-rodriguez

Saw this line and realized it would fail on python 2.7 if the user provides a unicode rather than a string:

if isinstance(dbpath, str):

If we add six to the list of requirements, we could do something like:
if isinstance(dbpath, six.string_types):
to treat both str and unicode the same way in both python 2 and 3. However, we can also get away without updating this at the moment.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions