Feat/require minter - #554
Merged
Merged
Conversation
[codex] fix sdk balance decimals
…d access - Add require_minter(env, minter) to admin module as convenience guard - Update token contract mint() and batch_mint() to accept minter parameter - Replace direct admin auth with require_minter role check - Update Rust tests to pass minter address - Update TS SDK to pass source public key as minter - Update mock client and tests to match new API - Remove outdated test snapshots (will regenerate on next run)
Contributor
Author
|
Please merge |
|
@barry01-hash Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
# Conflicts: # SECURITY.md # contracts/admin/src/lib.rs # contracts/token/src/lib.rs # contracts/token/src/test.rs # contracts/token/test_snapshots/test/test_approve_and_transfer_from.1.json # contracts/token/test_snapshots/test/test_initialize_emits_correct_event.1.json # indexer/src/indexer.ts # sdk/README.md # sdk/package.json # sdk/src/client.ts # sdk/tsconfig.json
- Fix indentation of read_supply and admin functions in lib.rs - Fix extra brace and source optionality in SDK mint method - Fix batchMint recipient key from 'address' to 'to' matching upstream struct - Update test to expect 'to' key
- Remove allow(clippy::manual_assert) from both contracts - Fix indentation of Ok(()) in internal_mint - Fix blank line before #[contractimpl] - Fix indentation of transfer_ownership and allowance_data - Fix blank line between transfer_ownership and pause
- proptest.rs: fix 'static lifetime compilation error, fix mint calls to use admin as minter (role-based access), fix assertion bug in test_core_invariants tracking balance_a instead of hardcoded values - test.rs: remove Vec type annotation (pre-existing compile error) - vesting/lib.rs: update mint call to pass minter as first arg (3-param signature) - client.balance.test.ts: fix test expectations to match getBalance returning bigint and calling queryContract once - Regenerate test snapshots to match new behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #451
What does this PR do?
Type of change
Checklist
pre-commit run --all-fileslocally and it passedBreaking changes?
Related issues
Closes #