Repository navigation
fix(security): validate daemon requests and update vulnerable dependencies - #280
Merged
Merged
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters: 2
📒 Files selected for processing: 15
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keep the daemon available when unauthenticated clients send invalid requests or reset their connections, and update vulnerable runtime and documentation dependencies for the next release.
Why
Request-validation and connection errors could stop the daemon before authentication. The runtime and documentation lockfiles also contained dependencies with published security advisories.
How
Test plan
pixi run check: 3,096 passed, 6 skipped; 92.35% coverage; Ruff and mypy clean.pip-auditandnpm auditalso clean.Local GPU smoke testing was attempted in an isolated session: 7 checks passed, while replay-dependent checks could not run because the tracked NVIDIA capture is incompatible with the available AMD RX 7600. The pre-push hook was bypassed using its documented option for this hardware limitation; remote required checks remain enforced.