Repository navigation
fix(daemon): isolate RPC resets and add persistent diagnostics - #279
Draft
BANANASJIM wants to merge 1 commit into
Draft
BANANASJIM wants to merge 1 commit into
BANANASJIM wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keep the replay daemon serving subsequent RPCs when an accepted client connection resets during request reception, and add opt-in persistent diagnostics for intermittent connection failures.
Why
Refs #278, including the single-PickPixel report. The report includes both persistent failures after a script and isolated descriptor-query failures followed by successful queries. Their root cause is still unconfirmed.
The server currently lets receive-side
ConnectionResetErrorescape its accept loop and silently discards response-send errors. This draft fixes the confirmed connection-isolation defect and collects evidence for the remaining failures.How
RDC_DAEMON_LOGbefore launching a daemon to retain diagnostic records and enablefaulthandler; log PID, Python/platform, and the actual RenderDoc version/module path..stderrcompanion file. Windows does not preserve CRT append metadata across subprocess handle inheritance, so separate files avoid competing writers overwriting diagnostics.Test plan
statusresponse from the same daemon; both log files retained.pixi run checkon Python 3.14.2 and pre-push e2e smoke with RenderDoc 1.41: 26 passed, 0 failed.This remains a draft pending Windows and reporter-capture verification; it does not claim to resolve an unknown native PickPixel fault or close #278.