Skip to content

fix: update native dependencies for v0.1.29 - #527

Merged
BANANASJIM merged 3 commits into
mainfrom
fix/native-security-dependencies-20261023
Oct 23, 2026
Merged

BANANASJIM merged 3 commits into
mainfrom
fix/native-security-dependencies-20261023

Conversation

@BANANASJIM

Copy link
Copy Markdown
Owner

Update the statically linked libusb to 1.0.30 and wasm3 to the unmodified upstream 0.9.0 sources. Validate and compile plugin functions before exposing callbacks, and reject invalid modules without leaking runtime state. Prepare the v0.1.29 security maintenance release.

The USB descriptor regression fails against the old dependency and passes after the update; invalid WASM type validation also fails before the fix. Normal plugin loading and reload behavior remain covered.

Validation: canonical Docker unit tests (2,117 passed, 11 skipped), ReleaseSafe and ThreadSanitizer (2,113 passed, 11 skipped each), formatting, optional WASM/libusb-disabled builds, and x86_64/aarch64 Linux musl release builds all pass. Upstream source integrity and dependency hashes were verified independently.

OSV-2021-689 remains open upstream without a published fixed revision. This release does not claim that advisory is resolved; hardware/UHID tests and a full Nix build were not run.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4c5b8162-f818-4288-8563-c81bb61f6f66
📥 Commits

Reviewing files that changed from the base of the PR and between fe324c1 and 01fc31e.

⛔ Files ignored due to path filters: 2
  • tests/wasm/invalid_global_initializer.wasm is excluded by !**/*.wasm
  • tests/wasm/invalid_result_type.wasm is excluded by !**/*.wasm
📒 Files selected for processing: 37
  • .github/workflows/release.yml
  • THIRD_PARTY.md
  • build.zig
  • build.zig.zon
  • build.zig.zon2json-lock
  • src/wasm/wasm3_backend.zig
  • tests/libusb_descriptor_security.c
  • tests/wasm/README.md
  • tests/wasm/invalid_global_initializer.wat
  • tests/wasm/invalid_result_type.wat
  • third_party/libusb/config.h
  • third_party/wasm3/LICENSE
  • third_party/wasm3/README.vendor
  • third_party/wasm3/source/m3_api_libc.c
  • third_party/wasm3/source/m3_api_libc.h
  • third_party/wasm3/source/m3_api_meta_wasi.c
  • third_party/wasm3/source/m3_bind.c
  • third_party/wasm3/source/m3_compile.c
  • third_party/wasm3/source/m3_compile.h
  • third_party/wasm3/source/m3_config.h
  • third_party/wasm3/source/m3_config_platforms.h
  • third_party/wasm3/source/m3_core.c
  • third_party/wasm3/source/m3_core.h
  • third_party/wasm3/source/m3_env.c
  • third_party/wasm3/source/m3_env.h
  • third_party/wasm3/source/m3_exec.h
  • third_party/wasm3/source/m3_function.c
  • third_party/wasm3/source/m3_function.h
  • third_party/wasm3/source/m3_info.c
  • third_party/wasm3/source/m3_math_utils.h
  • third_party/wasm3/source/m3_module.c
  • third_party/wasm3/source/m3_parse.c
  • third_party/wasm3/source/m3_validate.c
  • third_party/wasm3/source/m3_validate.h
  • third_party/wasm3/source/wasm3.h
  • third_party/wasm3/source/wasm3_defs.h
  • tools/build_libusb.zig
+------------------------------------------+
| Every day I'm shufflin'... through code. |
+------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BANANASJIM
BANANASJIM merged commit 049953d into main Oct 23, 2026
40 of 41 checks passed
@BANANASJIM
BANANASJIM deleted the fix/native-security-dependencies-20261023 branch October 23, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant