Repository navigation
fix: make bf2_runtime_pair link again (WorldPref::mTickCount) - #66
Merged
Merged
Conversation
The grenade trace compiled into PointPhysicsNode.cpp reads the tick count, whose definition lives in Core/System.cpp. The harness does not link that file, so bf2_runtime_pair failed with LNK2019 and bf2_run_checks never ran. Add a test-only [TEMP] definition. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Thanks for contributing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red x86 CI job on main. bf2_runtime_pair fails to link with LNK2019
dice::hfe::WorldPref::mTickCount: GrenadeTrace.h (added in e44067b) logs the tick count, and
PointPhysicsNode.cpp, which is in the test's source list, includes it. The real definition is in
Core/System.cpp, which the test does not link.
Adds a [TEMP] test-only definition of WorldPref::mTickCount in Code/Tests/runtime_pair.cpp. The
grenade trace is not armed in the tests, so the counter only has to exist. No game code changed;
runtime_pair.cmd uses the same .cpp, so it is covered without changes.
Local CI check
Local mirror of the Windows jobs in .github/workflows/build.yml, run on main (ccf3099)
plus #64, #65 and #66 together (not one by one), from empty build dirs:
Toolchain: VS 2026 (MSVC 19.51); CI uses VS 2022. Linux job not run locally.