kickstart ui cleanup: shared dropdown, collapsible checks, base cost estimate, region prefs - #2326
Draft
David Gamero (davidgamero) wants to merge 6 commits into
Draft
Conversation
David Gamero (davidgamero)
marked this pull request as draft
July 20, 2026 21:40
Add a generalized SearchableDropdown<T> (fuzzy search + full keyboard/a11y: arrow nav with wraparound, Home/End, Enter/Escape/Tab, scrollIntoView, drop-up, ARIA) with generic items via getValue/toLabel/sortKey. Migrate all 7 kickstart dropdowns (6 in KickstartCluster, 1 github-repo in KickstartGuidedSetup) to it. Old TextWithDropdown/CustomDropdown kept for the 12 non-kickstart usages.
Wrap the preflight check list in a CollapsibleStageGroup that shows a one-line 'Pre-flight checks — N of M passed' summary, auto-collapsing once all checks pass and auto-expanding while running or on failure. Add hideEntriesWhenSucceeded to ActivityStageList so succeeded stages render just title + detail (no leftover clock/elapsed entry rows). De-duplicate the providers check (already shown during the region scan) and normalize stacked-section spacing (checkDetail margin, permission warning gap).
David Gamero (davidgamero)
force-pushed
the
review/kickstart-dropdown-state
branch
from
August 3, 2026 20:36
b3c4ab2 to
f7a822b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kickstart ui cleanup pass — dropdowns + preflight checks. (region-pref + cost-estimate changes split out into #2327.)
dropdowns
SearchableDropdown<T>component (fuzzy search + full keyboard/a11y: arrow nav w/ wraparound, home/end, enter/escape/tab, scrollIntoView, drop-up, aria) — best-of-both of the oldTextWithDropdownandCustomDropdowngetValue/ optionaltoLabel/ optionalsortKey(sortKey sets default order + tiebreaks equal fuzzy scores)(private); label composition moved out of jsx intotoLabelpreflight checks density
pre-flight checks — N of M passedsummaryproviderscheck (was showing during the region scan AND in preflight)DisclosureButtonso the three collapse toggles (full-error, capacity-checks, stage-group) share one impl + css instead of three copiesnotes
npm run buildall clean