Reorganize versioning docs out of ARM subdirectory#4217
Reorganize versioning docs out of ARM subdirectory#4217
Conversation
markcowl
left a comment
There was a problem hiding this comment.
In addition to the changes outlined in my review, look through the documents looking for examples, and, in each case where there is an example that would be significantly different for ARM versus data-plane (operations are significantly different for ARM versus data-plane APIs, for example)
Once changes are made, ensure that all files are correctly formatted, there are no misspellings, and no merge issues with main after you pull the latest changes.
Reviewed all documents for ARM vs data-plane differences. Added data-plane equivalents alongside ARM operation examples in:
Model-level examples (adding/removing properties, renaming, etc.) are unchanged since they work identically for both ARM and data-plane. All files checked with codespell — no spelling issues. Merge with main verified clean. Done in c6aa80b. |
|
/azp run typspec-azure - PR Tools |
|
No pipelines are associated with this pull request. |
|
/azp run typespec-azure - PR Tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
No changes needing a change description found. |
|
You can try these changes here
|
|
@copilot please pull the latest from main, ensure there are no merge issues, and verify that only your changes are in the PR |
c6aa80b to
31077eb
Compare
markcowl
left a comment
There was a problem hiding this comment.
Make these changes, pull the latest from main, ensure that there are no merge conflicts, all files are correctly formatted, and the pr contains only your changes
All changes applied, rebased on latest main with no conflicts, verified only documentation changes are in the PR. Done in 2e94dc2. |
1cbd017 to
637db28
Compare
|
|
||
| - [How to manage a single active preview if your service always has some features in preview (ARM only)](./uncommon-scenarios/02-perpetual-preview.md) | ||
|
|
||
| ## Should I Retain the OpenAPI for an Old Preview API (ARM Only) |
There was a problem hiding this comment.
I believe data-plane is doing this as well, at the very least I dont believe anybody is going back and removing old preview swaggers for dp either
There was a problem hiding this comment.
They will actually be prevented from doing this by TypeSpec Validation, so my guess is that by and large they are not.
I just ran into a PR for a data plane that decided they needed to do this for no good reason because the documentation was there. I would really like to discourage everyone from leaving their old preview specs around, but for some ARM specs, doing so is potentially catastrophic
There was a problem hiding this comment.
Is this a relatively new addition to typespec validation? I havent seen this enforced in any pr I've run across. This is an older spec on TypeSpec that has several older previews checked in, but only has the current stable versions in versioning enum: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cognitiveservices/ContentSafety/main.tsp
Another older service with this same issue: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/ai/DocumentIntelligence/main.tsp
This service is in a slightly different boat because it still specifies all the previews in the api version enum: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/ai/Face/main.tsp
so just wanted to call out that this doesnt seem to be enforced
markcowl
left a comment
There was a problem hiding this comment.
Make these changes, pull the latest from main, validate that all files are correctly formateed and only your changes are in the PR
…ntroductions, update links Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/e3f6341b-5c80-4f75-8fe5-e8b9a30074e8 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
…ll references Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/5ae43f24-5a9b-4ac4-9c08-9ef4240f81c4 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/5ae43f24-5a9b-4ac4-9c08-9ef4240f81c4 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
…e examples, update headings Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/83ebf765-92d4-4c47-8eab-eb4aa807c173 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
…Required section, apply suggestions, remove data-plane examples Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/56c71242-0384-4237-b485-c9d866377d88 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
…ting Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/6fc3dfbd-f127-4697-8ab5-5d2db938f57d Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
…tion, move Note to ARM section Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/557330e7-cce9-4916-94ca-12a9636bc60c Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
637db28 to
9282536
Compare
All review changes applied, rebased on latest main, all files pass prettier formatting, and only versioning doc changes are in the PR diff. Done in 9282536. |
|
/azp run typespec-azure - PR Tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
website/astro.config.mjsfor all moved/renamed/deleted docs01-about-versioning.md##heading in 01-about-versioning.md