Improve quickstart deployment validation - #501
Open
Steven Ma (stevenjma) wants to merge 2 commits into
Open
Conversation
Add correlation-backed metadata validation and a maintainer-triggered /validate workflow for Terraform quickstarts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
Steven Ma (@stevenjma) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Filter changed-files output to existing quickstart sample directories before invoking metadata and Terraform validation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/validatecommandmetadata.jsondeployment evidence usingARM_CORRELATION_REQUEST_IDARM_Deployments_Terraform_v2Security model
/validatebefore entering the protected environmentterraform-deployment-validationagainst the exact PR head SHAValidation
git diff --checkRollout prerequisite
Create the
adx-readonlyGitHub environment withAZURE_TENANT_ID,AZURE_SUBSCRIPTION_ID, andAZURE_UAMI_CLIENT_ID. Its federated identity needs read-only query access toAPAProdonhttps://apadata.westus.kusto.windows.net.The
issue_commentworkflow must exist on the default branch before/validatecomments can execute, so end-to-end command testing occurs after merge. Open PRs #499, #498, and #497 are suitable single-quickstart candidates once they add freshmetadata.jsonevidence.