Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# Go 1.26.6 Toolchain Upgrade

## Requirements
- Upgrade the same files changed by PR #403 from Go 1.25.13 to Go 1.26.6.

## Additional comments from user
- Upgrade same files from PR #403 to 1.26.6.

## Plan
1. Update the Go directive, Docker builder images, and CI Go version variables.
2. Verify all targeted references are updated and no stale references remain.
3. Run applicable validation, secret scanning, and CodeQL checks.

## Decisions
- Keep the scope identical to PR #403: the four Dockerfiles, six workflows, and `go.mod`.

## Implementation Details
- Updated the Go directive and Docker builder image tags to `1.26.6`.
- Updated the six workflow `GO_VERSION` values to `1.26.6`.

## Changes Made
- `go.mod`
- `docker/hub-net-controller-manager.Dockerfile`
- `docker/mcs-controller-manager.Dockerfile`
- `docker/member-net-controller-manager.Dockerfile`
- `docker/net-crd-installer.Dockerfile`
- `.github/workflows/go.yml`
- `.github/workflows/build-publish-mcr.yml`
- `.github/workflows/unit-integration-tests.yml`
- `.github/workflows/trivy.yml`
- `.github/workflows/e2e-tests.yml`
- `.github/workflows/publish-image.yml`

## Before/After Comparison
- Go 1.25.13 references in the PR #403 files are now Go 1.26.6.

## References
- PR #403: Go toolchain bump from 1.25.12 to 1.25.13.
2 changes: 1 addition & 1 deletion .github/workflows/build-publish-mcr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:
# `public` indicates images to MCR wil be publicly available, and will be removed in the final MCR images
REGISTRY_REPO: public/aks/fleet

GO_VERSION: '1.25.13'
GO_VERSION: '1.26.6'

jobs:
prepare-variables:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions:
contents: read

env:
GO_VERSION: '1.25.13'
GO_VERSION: '1.26.6'

jobs:
detect-noop:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:

env:
# Common versions
GO_VERSION: '1.25.13'
GO_VERSION: '1.26.6'

jobs:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ env:
REGISTRY: ghcr.io
IMAGE_VERSION: latest

GO_VERSION: '1.25.13'
GO_VERSION: '1.26.6'

jobs:
export-registry:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trivy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ env:
MEMBER_NET_CONTROLLER_MANAGER_IMAGE_NAME: member-net-controller-manager
MCS_CONTROLLER_MANAGER_IMAGE_NAME: mcs-controller-manager

GO_VERSION: '1.25.13'
GO_VERSION: '1.26.6'

jobs:
export-registry:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ permissions:
contents: read

env:
GO_VERSION: '1.25.13'
GO_VERSION: '1.26.6'

jobs:
detect-noop:
Expand Down
2 changes: 1 addition & 1 deletion docker/hub-net-controller-manager.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the hub-net-controller-manager binary
FROM mcr.microsoft.com/oss/go/microsoft/golang:1.25.13 AS builder
FROM mcr.microsoft.com/oss/go/microsoft/golang:1.26.6 AS builder

ARG GOOS=linux
ARG GOARCH=amd64
Expand Down
2 changes: 1 addition & 1 deletion docker/mcs-controller-manager.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the mcs-controller-manager binary
FROM mcr.microsoft.com/oss/go/microsoft/golang:1.25.13 AS builder
FROM mcr.microsoft.com/oss/go/microsoft/golang:1.26.6 AS builder

ARG GOOS=linux
ARG GOARCH=amd64
Expand Down
2 changes: 1 addition & 1 deletion docker/member-net-controller-manager.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the member-net-controller-manager binary
FROM mcr.microsoft.com/oss/go/microsoft/golang:1.25.13 AS builder
FROM mcr.microsoft.com/oss/go/microsoft/golang:1.26.6 AS builder

ARG GOOS=linux
ARG GOARCH=amd64
Expand Down
2 changes: 1 addition & 1 deletion docker/net-crd-installer.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the net-crd-installer binary
FROM mcr.microsoft.com/oss/go/microsoft/golang:1.25.13 AS builder
FROM mcr.microsoft.com/oss/go/microsoft/golang:1.26.6 AS builder

ARG GOOS=linux
ARG GOARCH=amd64
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module go.goms.io/fleet-networking

go 1.25.13
go 1.26.6

require go.goms.io/fleet v0.14.0

Expand Down
Loading