Fix #389 : Replace check with Ansible version comparison - #395
Open
James Flynn (james-flynn-ie) wants to merge 1 commit into
Open
Fix #389 : Replace check with Ansible version comparison#395James Flynn (james-flynn-ie) wants to merge 1 commit into
James Flynn (james-flynn-ie) wants to merge 1 commit into
Conversation
Previous String check was broken when version rolled over to 2.10.0, since it was comparing Strings rather than version numbers. Ansible's version comparison function (https://docs.ansible.com/ansible/latest/user_guide/playbooks_tests.html#comparing-versions) fixes this issue.
|
Please https://twitter.com/Azure, review and approve! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #389. The String comparison method was broken when the Ansible version rolled over to 2.10.0, since it was comparing Strings rather than version numbers.
Ansible's version comparison function (https://docs.ansible.com/ansible/latest/user_guide/playbooks_tests.html#comparing-versions) fixes this issue.
Will also resolve Azure-Samples/ansible-playbooks#88, which depends on this role.